Re: Asking for advice on gcc/config/{pa/pa,rs6000/rs6000}-protos.h

[Jeffrey A Law <law at cygnus dot com>]

  In message <9150F3E779F0D211BD370008C733141C38AA6A@aus-msg-02.au.pmsc.com>you
 write:
  > This message is in MIME format. Since your mail reader does not understand
  > this format, some or all of this message may not be legible.
  > 
  > ------_=_NextPart_001_01BF5754.177CEA38
  > Content-Type: text/plain;
  > 	charset="ISO-8859-1"
FYI, it's really a pain to read your messages because of your mime
encodings & nonstandard charsets.  Why bother using encoding at all since
you're sending plaintext?


  > I looked at cleaning up some of the warnings in gcc/config/pa/pa.c,
  > followed the examples of the gcc/config/*/*-protos.h and implemented it
  > for HPPA.
  > 
  > 1. The <<arch>>/<<arch>>-protos.h files for alpha, arm, c4x, fr30, i386,
  > 	mr32r, mips, sparc, v850
  >     all seem to have different formating styles. Which is preferred
  >     or should I use the style using for predeclaring the static functions
  >     in pa/pa.c?
You should follow the GNU coding standards.  If the other files are not
following GNU coding standards then they should be fixed.

  > 	 If PROTO is deprecated (gcc/gansidecl.h) should PROTO be converted
  >     to PARAMS in alpha, arm, fr30, i386, m32r, v850 on the next necessary
  >     edit of -protos.h in those directories?
We really need to bite the bullet and change all the PROTO -> PARAMS throughout
GCC.  GCC is the only major code using PROTO if I remember correctly.


  > 2. Must I have a copyright assignment for just providing a list of ANSI
  > 	declarations - does it still count as a minor change?
Yes.


  > 3. Should the PARAMS declarations include register or ATTRIBUTE_UNUSED
  >  	for parameter types so declared? On HPPA and Power arguments are
  > 	register resident anyway, so what does the register declaration
  > 	of arguments gain? (Excepting register poor cross compilers)
  > 	(I note the other -protos.h don't include these).
I do not think the UNUSED stuff is useful or necessary in the PARAMS
declarations.  The UNUSED attribute is only useful in the function
definition itself.