This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Asking for advice on gcc/config/{pa/pa,rs6000/rs6000}-protos.h


Title: Asking for advice on gcc/config/{pa/pa,rs6000/rs6000}-protos.h

I looked at cleaning up some of the warnings in gcc/config/pa/pa.c,
followed the examples of the gcc/config/*/*-protos.h and implemented it
for HPPA.

1. The <<arch>>/<<arch>>-protos.h files for alpha, arm, c4x, fr30, i386,
        mr32r, mips, sparc, v850
    all seem to have different formating styles. Which is preferred
    or should I use the style using for predeclaring the static functions
    in pa/pa.c?
         If PROTO is deprecated (gcc/gansidecl.h) should PROTO be converted
    to PARAMS in alpha, arm, fr30, i386, m32r, v850 on the next necessary
    edit of -protos.h in those directories?

2. Must I have a copyright assignment for just providing a list of ANSI
        declarations - does it still count as a minor change?

3. Should the PARAMS declarations include register or ATTRIBUTE_UNUSED
        for parameter types so declared? On HPPA and Power arguments are
        register resident anyway, so what does the register declaration
        of arguments gain? (Excepting register poor cross compilers)
        (I note the other -protos.h don't include these).

I think that the extra (insn_code_number) argument to constrain_operands in
pa/pa.c:pa_can_combine_p at ~ 6518 was the only thing found that could affect
code generation - the rest were trailing ATTRIBUTE_UNUSED arguments that weren't
supplied.

Haven't done rs6000 yet
Waiting on make check for hpux10.20 - will build on 11 when I confirm 10.20
is Ok and provide patches after.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]