This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: agressive fixincludes
- To: "Bruce Korb" <ddsinc09 at ix dot netcom dot com>
- Subject: Re: agressive fixincludes
- From: Raja R Harinath <harinath at cs dot umn dot edu>
- Date: 23 Nov 1999 13:37:29 -0600
- Cc: gcc at gcc dot gnu dot org, autogen at linuxbox dot com
- References: <19991123143237.7196.qmail@sourceware.cygnus.com>
korbb@sourceware.cygnus.com writes:
> I suspect that the real problem is that IA86-Linux got switched
> from a special purpose script to the general purpose program.
> The program is actually seems much more careful than the old sed
> script from the fixincludes script.
BTW, this causes another problem. AFAI can make out, even though the
old fixinc.ix86-pc-linux-gnu script was folded into the generic fixinc
framework, it isn't working. The 'inclhash.sh' file has the following:
# Skip unreadable files, symlinks to directories and glibc files
if test ! -r "${file}" || test -d "${file}/." \
|| fgrep 'This file is part of the GNU C Library' "${file}" \
> /dev/null 2>&1; then
continue
fi
[snip]
#
# Fix 10: Aab_Fd_Zero_Glibc_2_0
#
case "${file}" in ./selectbits.h )
if ( test -n "`egrep 'i[34567]86-*-linux-gnu*' ${file}`"
) > /dev/null 2>&1 ; then
echo "aab_fd_zero_glibc_2_0 replacing file ${file}" >&2
cat > ${DESTFILE} << '_EOF_'
[snip]
Firstly, selectbits.h is part of glibc, and the first segment removes
it from consideration for fixing. Even if it was, the test -n
'egrep..' seems bogus. That file doesn't have that string on my
machine, but it still needs the fix listed.
- Hari
--
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions." -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing." -- Roy L Ash