RE: [fixinc patch] Re: misp-sgi-irix5.2 assembler-preprocessor error building libgcj

[korbb@egcs.cygnus.com]

Alexandre Oliva wrote:
> 
> On Jul 31, 1999, Tom Tromey <tromey@cygnus.com> wrote:
> 
> >>>>>> "Alexandre" == Alexandre Oliva <oliva@dcc.unicamp.br> writes:
> Alexandre> In file included from /home/phd/oliva/src/libgcj-2.95/boehm-gc/mips_sgi_mach_dep.s:2:
> Alexandre> /usr/include/sys/asm.h:620: unterminated string or character constant
> 
> Alexandre> oliva@escher% sed -n 620p /usr/include/sys/asm.h
> Alexandre> # Now we're executing in Kernel Physical (KP) space
> Alexandre>         ^ the culprit
> 
> > Did you ever get an answer to this?
> 
> Nope.  Here's a patch for gcc.  Is this ok to install?  Release
> branch?

You never got an answer because I never saw the email.
Throughout July, email was flaky and I was not 100% on
scanning patches & bugs, unless "fixinc" was in the subject.
Anyway, there is a problem with it:

 /*
+ *  IRIX 5.2's <sys/asm.h> contains an asm comment with a contraction
+ *  that causes the assembly preprocessor to complain about an
+ *  unterminated character constant.
+ */
+fix = {
+    hackname = irix_asm_apostrophe;
+    files    = sys/asm.h;
+
+    select   = "^[ \t]#.*[Ww]e're";
+    sed      = "s/'/ a/";
+}

This fix will select files named "sys/asm.h" that contains 
a line that starts with either a space or a tab followed by
a hash mark followed somewhere on the line by a "[Ww]e're".
Once the file is selected, you will replace the first occurrance
of every apostorphe with a space and an 'a'.  I don't think so.
Do you mean this, instead?

 /*
+ *  IRIX 5.2's <sys/asm.h> contains an asm comment with a contraction
+ *  that causes the assembly preprocessor to complain about an
+ *  unterminated character constant.
+ */
+fix = {
+    hackname = irix_asm_apostrophe;
+    files    = sys/asm.h;
+
+    select   = "^[ \t]*#.*[Ww]e're";
+    sed      = "/^[ \t]*#/s/\\([Ww]e\\)'re/\\1 are/";
+}