Re: Can we have egcs 1.0.3 please?

> 
> 
>   In message <m0yQNZt-00058vC@ocean.lucon.org>you write:
>   > There is a bad typo in libio. I have sent a patch twice.
> I asked Ulrich to take a look at the libio patch not too long
> ago.  I haven't heard back from him yet.
> 
> I'd really like everything going into the 1.0.3 tree to have
> been reviewed by at least one person other than the author.
> 
> Maybe if you explained what is wrong and how your patch fixes
> the problem, someone could try to evaluate the patch.  Instead
> you just said "it's a typo" with zero explanation about what's
> going on.

See

http://www.cygnus.com/ml/egcs-bugs/1998-Apr/0028.html
http://www.cygnus.com/ml/egcs-bugs/1998-Apr/0046.html

I am enclosing my original patch with the typo in it here. As you can
see, I changed "count" to "_gcount" in "if" without removing count.

-- 
H.J. Lu (hjl@gnu.org)
---
--- /home/work/misc/gnu/import/egcs/libio/isgetline.cc	Thu Aug 21 15:58:19 1997
+++ isgetline.cc	Mon Feb 16 10:48:27 1998
@@ -67,8 +68,9 @@
   if (ipfx1())
     {
       streambuf *sbuf = rdbuf();
-      long count = _IO_getline(sbuf, buf, len - 1, delim, -1);
-      if (count == 0 && sbuf->sgetc() == EOF)
+      int ch;
+      long count = _IO_getline_info(sbuf, buf, len - 1, delim, -1, &ch);
+      if (_gcount == 0 && ch == EOF)
 	set(ios::failbit|ios::eofbit);
       else
 	_gcount = count;


From owner-egcs@cygnus.com  Sun Apr 26 17:37:45 1998
Received: (from majordom@localhost)