This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Exception size reduction patch


> 
> I think it would make more sense to use __attribute__ ((weak)), which
> should work for any target that supports weak declarations, and which
> will be harmless if it doesn't.  This is better than checking for
> HANDLE_SYSV_PRAGMA, since not every target that supports weak declarations
> supports HANDLE_SYSV_PRAGMA.  I don't think you need to conditionalize the
> checks for non-zero function addresses.

How does __attribute__ ((weak)) work on the external function?

Neither

extern int __attribute__ ((weak)) foo ();

nor

extern int foo () __attribute__ ((weak));

works for me.

> 
> It isn't clear to me why you moved all of the eh.o stuff from libgcc2.c to
> frame.c.  That just seems to make the patch larger than it needs to be.
> 

It may be true.

H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]