This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: egcs-980315 powerpc-ibm-aix4.1.4.0 warning fixes ...
- To: meissner at cygnus dot com
- Subject: Re: egcs-980315 powerpc-ibm-aix4.1.4.0 warning fixes ...
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Thu, 26 Mar 1998 11:31:54 -0500 (EST)
- Cc: egcs at cygnus dot com, law at cygnus dot com
> From: Jeffrey A Law <law@hurl.cygnus.com>
>
> Don't you need to make sure system.h is included in rs6000.c so that
> you get size_t via one of the standard system include files?
Well, it turns out that on AIX4, stdio.h declares size_t. (I of
course did test the patch to make sure it bootstrapped) but you're right
that including system.h is safer.
> From: Michael Meissner <meissner@cygnus.com>
>
> The part of rs6000.h that adds the declaration for:
>
> extern enum direction function_arg_padding ();
>
> is wrong, since it depends on the compiler supporting unknown tags to
> enums, which is a GCC extension. I have fixed this by making the
> function an integer function. I also included system.h as Jeff
> pointed out and committed the fixes (including collect2.c and
> dbxout.c).
Hmm, when I did the bootstrap test I used cc for stage1, so
maybe AIX4 cc supports it too? But in any case, your solution makes for
more portable code. So thanks for making the corrections and for
commiting the patch. :-)
One thing I noticed is that in adding system.h, you left in some
OS headers which duplicate stuff brought in by system.h. This patch
fixes it, would you please consider it too?
Thanks,
--Kaveh
--- rs6000.c~ Thu Mar 26 11:27:30 1998
+++ rs6000.c Thu Mar 26 11:27:55 1998
@@ -19,8 +19,6 @@
the Free Software Foundation, 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */
-#include <stdio.h>
-#include <ctype.h>
#include "config.h"
#include "system.h"
#include "rtl.h"
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu Icon CMT Corp.