This is the mail archive of the
gcc-regression@gcc.gnu.org
mailing list for the GCC project.
Re: Fixing expected regression-tester complaints for "new" fortrancross failures
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Geoff Keating <geoffk at redhat dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>, <gcc-regression at gcc dot gnu dot org>
- Date: Sat, 13 Apr 2002 08:06:42 -0400 (EDT)
- Subject: Re: Fixing expected regression-tester complaints for "new" fortrancross failures
On Mon, 8 Apr 2002, Geoff Keating wrote:
> > Date: Mon, 8 Apr 2002 21:15:05 -0400 (EDT)
> > From: Hans-Peter Nilsson <hp@bitrange.com>
> > On Mon, 8 Apr 2002, Geoff Keating wrote:
> > > > Date: Mon, 8 Apr 2002 19:50:54 -0400 (EDT)
> > > > From: Hans-Peter Nilsson <hp@bitrange.com>
> > > > Refer to
> > > > <URL:http://gcc.gnu.org/ml/gcc-patches/2002-04/msg00381.html>.
> > > > Should I add powerpc-*-* to the xfail target list in
> > > > <URL:http://gcc.gnu.org/ml/gcc-patches/2002-04/msg00425.html>?
> > > > Or do those tests need to pass to shut it up?
> > >
> > > So long as the tests you're adding have new names, it's unnecessary to
> > > do anything special. The tester will never have seen the tests pass
> > > and so won't consider their failures to be regressions.
> >
> > Misunderstanding: the failures are new, the tests are old
> > (evident at the URLs). For most of the tests, it's now a
> > compile-time failure where it was a run-time failure before, but
> > there are some tests that now only fail at compile-time. Read
> > the URLs for more.
>
> In that case, probably XFAIL is the best choice. The treats XFAIL the
> same way as if the test wasn't there---it is neither a fail nor a pass.
Given that, the following patch is obvious. Committed trunk,
will do on 3.1 branch too.
gcc/testsuite:
* g77.f-torture/execute/980628-4.x,
g77.f-torture/execute/980628-5.x,
g77.f-torture/execute/980628-6.x, g77.f-torture/execute/alpha2.x,
g77.f-torture/execute/auto0.x, g77.f-torture/execute/auto1.x,
g77.f-torture/compile/alpha1.x: xfail powerpc-*-* hosted on
i[34567]86-*-*.
Index: g77.f-torture/compile/alpha1.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/compile/alpha1.x,v
retrieving revision 1.2
diff -p -c -r1.2 alpha1.x
*** g77.f-torture/compile/alpha1.x 8 Apr 2002 23:16:17 -0000 1.2
--- g77.f-torture/compile/alpha1.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
Index: g77.f-torture/execute/980628-4.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/execute/980628-4.x,v
retrieving revision 1.2
diff -p -c -r1.2 980628-4.x
*** g77.f-torture/execute/980628-4.x 8 Apr 2002 23:16:15 -0000 1.2
--- g77.f-torture/execute/980628-4.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
Index: g77.f-torture/execute/980628-5.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/execute/980628-5.x,v
retrieving revision 1.2
diff -p -c -r1.2 980628-5.x
*** g77.f-torture/execute/980628-5.x 8 Apr 2002 23:16:15 -0000 1.2
--- g77.f-torture/execute/980628-5.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
Index: g77.f-torture/execute/980628-6.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/execute/980628-6.x,v
retrieving revision 1.2
diff -p -c -r1.2 980628-6.x
*** g77.f-torture/execute/980628-6.x 8 Apr 2002 23:16:15 -0000 1.2
--- g77.f-torture/execute/980628-6.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
Index: g77.f-torture/execute/alpha2.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/execute/alpha2.x,v
retrieving revision 1.2
diff -p -c -r1.2 alpha2.x
*** g77.f-torture/execute/alpha2.x 8 Apr 2002 23:16:15 -0000 1.2
--- g77.f-torture/execute/alpha2.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
Index: g77.f-torture/execute/auto0.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/execute/auto0.x,v
retrieving revision 1.2
diff -p -c -r1.2 auto0.x
*** g77.f-torture/execute/auto0.x 8 Apr 2002 23:16:15 -0000 1.2
--- g77.f-torture/execute/auto0.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
Index: g77.f-torture/execute/auto1.x
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g77.f-torture/execute/auto1.x,v
retrieving revision 1.2
diff -p -c -r1.2 auto1.x
*** g77.f-torture/execute/auto1.x 8 Apr 2002 23:16:15 -0000 1.2
--- g77.f-torture/execute/auto1.x 13 Apr 2002 11:44:37 -0000
***************
*** 2,8 ****
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"] } {
set torture_compile_xfail [istarget]
}
}
--- 2,9 ----
# below, with a "sorry" message.
if { [ishost "i\[34567\]86-*-*"] } {
! if { [istarget "mmix-knuth-mmixware"]
! || [istarget "powerpc-*-*"] } {
set torture_compile_xfail [istarget]
}
}
brgds, H-P