This is the mail archive of the gcc-regression@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: GCC build failed with your patch on 2000-08-24T21:35:00Z.

To: Geoff Keating <geoffk at cygnus dot com>
Subject: Re: GCC build failed with your patch on 2000-08-24T21:35:00Z.
From: Greg McGary <greg at mcgary dot org>
Date: 24 Aug 2000 15:52:21 -0700
Cc: wilson at cygnus dot com, jason at redhat dot com, gcc-regression at gcc dot gnu dot org
References: <200008242221.PAA28868@sloth.cygnus.com> <200008242248.PAA13125@localhost.cygnus.com>

Geoff Keating <geoffk@cygnus.com> writes:

> Looks like the automated tester is missing a ChangeLog or two.
> 
> Anyway, the problem is this change:
> 
> 2000-08-24  Greg McGary  <greg@mcgary.org>
> 
>         * libiberty/random.c (end_ptr): Likewise.
> 
> because libiberty/random.c does not include libiberty.h.  It wouldn't
> have appeared under linux because libiberty/random.c isn't used there.
> 
> This patch fixes it.  Tested under linux by hacking config.cache to
> have ac_cv_func_random=${ac_cv_func_random=no}, reconfiguring, and
> building libiberty.  I can't see anything that actually uses this
> function, so I'll just hope it works.

Thanks.  I already committed a patch to just back it out.
On the grounds that the value added by using ARRAY_SIZE in this
file is too small to bother pulling in libiberty.h.

References:
- GCC build failed with your patch on 2000-08-24T21:35:00Z.
  - From: GCC regression checker
- Re: GCC build failed with your patch on 2000-08-24T21:35:00Z.
  - From: Geoff Keating

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]