This is the mail archive of the
gcc-prs@gcc.gnu.org
mailing list for the GCC project.
Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified
- From: Richard Henderson <rth at redhat dot com>
- To: nobody at gcc dot gnu dot org
- Cc: gcc-prs at gcc dot gnu dot org,
- Date: 12 Dec 2002 18:16:07 -0000
- Subject: Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified
- Reply-to: Richard Henderson <rth at redhat dot com>
The following reply was made to PR c/6815; it has been noted by GNATS.
From: Richard Henderson <rth@redhat.com>
To: Christian Ehrhardt <ehrhardt@mathematik.uni-ulm.de>
Cc: gcc-gnats@gcc.gnu.org, gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org,
nobody@gcc.gnu.org, dtucker@zip.com.au
Subject: Re: c/6815: [3.2/3.3 regression] ICE with longjmp if -fprofile-arcs -O is specified
Date: Thu, 12 Dec 2002 10:08:35 -0800
On Thu, Dec 12, 2002 at 01:37:26PM +0100, Christian Ehrhardt wrote:
> where e is NULL. insert_insn_on_edge in turn is called from
> flow_call_edges_add in cfganal.c:325 with this piece of code:
>
> | for (e = bb->succ; e; e = e->succ_next)
> | if (e->dest == EXIT_BLOCK_PTR)
> | break;
> |
> | insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
> | commit_edge_insertions ();
>
> which looks a bit strange if we keep in mind that insert_insn_on_edge
> will crash if the second parameter is NULL.
Indeed, this piece of code cannot handle a noreturn function
in the last block. The following should fix it.
r~
Index: cfganal.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cfganal.c,v
retrieving revision 1.30
diff -c -p -d -u -r1.30 cfganal.c
--- cfganal.c 11 Oct 2002 21:09:59 -0000 1.30
+++ cfganal.c 12 Dec 2002 18:07:41 -0000
@@ -320,10 +320,11 @@ flow_call_edges_add (blocks)
for (e = bb->succ; e; e = e->succ_next)
if (e->dest == EXIT_BLOCK_PTR)
- break;
-
- insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
- commit_edge_insertions ();
+ {
+ insert_insn_on_edge (gen_rtx_USE (VOIDmode, const0_rtx), e);
+ commit_edge_insertions ();
+ break;
+ }
}
}