libgcj/1242: build is broken on Linux/Alpha

[bryce at albatross dot co dot nz]

>Number:         1242
>Category:       libgcj
>Synopsis:       build is broken on Linux/Alpha
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tromey
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 20 12:18:12 PST 2000
>Closed-Date:    Thu Apr 20 20:51:32 PDT 2000
>Last-Modified:  Thu Apr 20 21:00:00 PDT 2000
>Originator:     Bryce McKinlay
>Release:        cvs libgcj as of 20000418
>Organization:
>Environment:
Redhat 6.2, Alpha EV6
>Description:
Various functions in java-cpool.h contain an #ifdef based on
word size in order to store longs and doubles in a single
word. However, the union _Jv_word in javaprims.h defines 
these conditionally on "__LP64__". This is not defined on
alpha, resulting in the following build error:

In file included from /home/bryce/libgcj/libjava/include/java-interp.h:15,
                 from /home/bryce/libgcj/libjava/jni.cc:47:
/home/bryce/libgcj/libjava/include/java-cpool.h: In function `void _Jv_storeLong(_Jv_word *, __java_long)':
/home/bryce/libgcj/libjava/include/java-cpool.h:84: `union _Jv_word' has no member named `l'
/home/bryce/libgcj/libjava/include/java-cpool.h: In function `jlong _Jv_loadLong(_Jv_word *)':
/home/bryce/libgcj/libjava/include/java-cpool.h:97: `union _Jv_word' has no member named `l'
/home/bryce/libgcj/libjava/include/java-cpool.h:104: warning: control reaches end of non-void function `_Jv_loadLong(_Jv_word *)'
/home/bryce/libgcj/libjava/include/java-cpool.h: In function `void _Jv_storeDouble(_Jv_word *, __java_double)':
/home/bryce/libgcj/libjava/include/java-cpool.h:110: `union _Jv_word' has no member named `d'
[etc etc]
>How-To-Repeat:
./configure && make
>Fix:
Change "#ifdef __LP64__" to "#if SIZEOF_VOID_P == 8" ??
>Release-Note:

>Audit-Trail:

Formerly PR libgcj/212

State-Changed-From-To: open->feedback
State-Changed-By: tromey
State-Changed-When: Thu Apr 20 15:25:02 2000
State-Changed-Why:
    I checked in a fix for this.
    Neither _Jv_word nor _Jv_word2 needed to be defined
    in gcj/javaprims.h.  I moved them to an implementation-
    specific header.
    Can you try it now?

From: tromey@sourceware.cygnus.com
To: java-gnats@sourceware.cygnus.com
Cc:  
Subject: libgcj/212
Date: 20 Apr 2000 22:24:33 -0000

 CVSROOT:	/cvs/java
 Module name:	libgcj
 Changes by:	tromey@sourceware.cygnus.com	00/04/20 15:24:33
 
 Modified files:
 	libjava        : ChangeLog 
 	libjava/java/lang: Class.h 
 	libjava/gcj    : javaprims.h 
 	libjava/include: jvm.h 
 
 Log message:
 	Fix for PR libgcj/212:
 	* gcj/javaprims.h (_Jv_word, _Jv_word2): Removed definitions.
 	* include/jvm.h (_Jv_word, _Jv_word2): Define.
 	* java/lang/Class.h (_Jv_word): Declare.
 
 Patches:
 http://gcc.gnu.org/cgi-bin/gcc/libjava/ChangeLog.diff?cvsroot=java&r1=1.349&r2=1.350
 http://gcc.gnu.org/cgi-bin/gcc/libjava/java/lang/Class.h.diff?cvsroot=java&r1=1.18&r2=1.19
 http://gcc.gnu.org/cgi-bin/gcc/libjava/gcj/javaprims.h.diff?cvsroot=java&r1=1.8&r2=1.9
 http://gcc.gnu.org/cgi-bin/gcc/libjava/include/jvm.h.diff?cvsroot=java&r1=1.21&r2=1.22
 

From: tromey@cygnus.com
To: bryce@albatross.co.nz, java-gnats@sourceware.cygnus.com, tromey@cygnus.com
Cc:  
Subject: Re: libgcj/212
Date: 20 Apr 2000 22:25:02 -0000

 Synopsis: build is broken on Linux/Alpha
 
 State-Changed-From-To: open->feedback
 State-Changed-By: tromey
 State-Changed-When: Thu Apr 20 15:25:02 2000
 State-Changed-Why:
     I checked in a fix for this.
     Neither _Jv_word nor _Jv_word2 needed to be defined
     in gcj/javaprims.h.  I moved them to an implementation-
     specific header.
     Can you try it now?
 
 http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=212&database=java
State-Changed-From-To: feedback->closed
State-Changed-By: tromey
State-Changed-When: Thu Apr 20 20:51:32 2000
State-Changed-Why:
    Jeff Sturm reports that this worked.

From: tromey@cygnus.com
To: bryce@albatross.co.nz, java-gnats@sourceware.cygnus.com, tromey@cygnus.com
Cc:  
Subject: Re: libgcj/212
Date: 21 Apr 2000 03:51:32 -0000

 Synopsis: build is broken on Linux/Alpha
 
 State-Changed-From-To: feedback->closed
 State-Changed-By: tromey
 State-Changed-When: Thu Apr 20 20:51:32 2000
 State-Changed-Why:
     Jeff Sturm reports that this worked.
 
 http://sourceware.cygnus.com/cgi-bin/gnatsweb.pl?cmd=view&pr=212&database=java
>Unformatted: