This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] musl: use correct long double abi by default
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: nd <nd at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Rich Felker <dalias at libc dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Andreas Krebbel <krebbel at linux dot ibm dot com>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Fri, 15 Nov 2019 18:03:25 +0000
- Subject: Re: [PATCH] musl: use correct long double abi by default
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hQres0Y4LHPvDkZ9U3c4okPaB+0m4MRE/b+99LMkA1A=; b=fs6YhLxXxIxfYGtU/IypNn93RLxPm9hm5rWi47kMwI5o1VdyZdm8pbaiPtSifrEV5yyvgVL/vL+LK2X/RaLjZwwH0yGHc7n45p+CgPpV9w2uwNRijCXRnysV2vImFfE5eo+UOlTzMz2Q6xU5ckCQq+ZQnrkRj6qaz4W4fnicPvpfj6zS39GvcPDFLidQs8pf4NhKyUP0DCAkiY9T2PU7wmbrKwOh8wbxNdmI82lU3cY0FpDG6j8TuS6zVeARZnWFEYsjyH+OycYt9lR7GV4fpVAogEy6xhpB6Gcmnu7Ue6bCVuXijWFsk7HKU/zx8hPbExWhkMi2lS2NNtOtn0JKPg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DCfuLQVy4YUOMl7YHSpHpIG9w55fGyM+7FE3uyj4jD64S+ebUVqgszoCJiwLTZdT7FvZgR8DB4tdj2s5pUHppJWP9epUxUH3aQXOJ9NpVA8IPiDXhcqpO7GMUxIIzBHLHgxqMRZKLNnW4tADQMO1cx1mbAEwIU96TorDnpa9WIl+owb8uBEecOAO9CJf1/t0PU7l5EMAbf1EsBZTCRHCe3LqyquLhRHHNG5S5+XcOuXhXz7Gkac19ctuSNI+a0UGkqf6I68MOe2x8A1fL2dtmwRyJX1bYrXVg9phZ9bPzmuDmcIQwN/AbRx8FPcry+5LBkkFM0ps7LkN5+sqcNYT7g==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- References: <2eb3f34c-d4e4-ce44-1c98-22bff6a9e654@arm.com> <20191115174822.GV16031@gate.crashing.org>
On 15/11/2019 17:48, Segher Boessenkool wrote:
> On Fri, Nov 15, 2019 at 05:26:41PM +0000, Szabolcs Nagy wrote:
>> On powerpc and s390x the musl ABI requires 64 bit and 128 bit long
>> double respectively, so adjust the default.
>>
>> gcc/ChangeLog:
>>
>> 2019-11-15 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>
>> * configure.ac: Set gcc_cv_target_ldbl128 for musl targets.
>> * configure: Regenerate.
>
> Please correct the changelog, then?
>
>> diff --git a/gcc/configure.ac b/gcc/configure.ac
>> index 1a0d68208e4..330d5fcaf68 100644
>> --- a/gcc/configure.ac
>> +++ b/gcc/configure.ac
>> @@ -6161,13 +6161,25 @@ case "$target" in
>> AC_ARG_WITH(long-double-128,
>> [AS_HELP_STRING([--with-long-double-128],
>> [use 128-bit long double by default])],
>> - gcc_cv_target_ldbl128="$with_long_double_128",
>> + gcc_cv_target_ldbl128="$with_long_double_128", [
>> + case "$target" in
>> + s390*-*-linux-musl*)
>> + gcc_cv_target_ldbl128=yes
>> + ;;
>> + powerpc*-*-linux-musl*)
>> + gcc_cv_target_ldbl128=no
>> + ;;
>> + *)]
>
> I think it would be much more readable and maintainable if you did
> something like
>
> case "$target" in
> powerpc*-*-linux-musl)
> gcc_cv_target_ldbl128=no
> ;;
> s390*-*-linux-musl)
> gcc_cv_target_ldbl128=yes
> ;;
> powerpc*-*-linux* |
> sparc*-*-linux* |
> s390*-*-linux* |
> alpha*-*-linux*)
> AC_ARG_WITH(long-double-128,
>
> etc., i.e. add the musl targets to the main switch here?
i'm fine with that, it means the --with-long-double-128
switch does not work on *-musl, which is not a huge
loss as the musl abi won't change, but i thought one
should be able to configure a non-default-abi toolchain
if it's a documented configure option for the target.
i'll try your simplified solution.