This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR92398: Fix testcase failure of pr72804.c
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Xiong Hu Luo <luoxhu at linux dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, wschmidt at linux dot ibm dot com
- Date: Fri, 15 Nov 2019 04:17:11 -0600
- Subject: Re: [PATCH] PR92398: Fix testcase failure of pr72804.c
- References: <20191115031232.130211-1-luoxhu@linux.ibm.com>
Hi!
On Thu, Nov 14, 2019 at 09:12:32PM -0600, Xiong Hu Luo wrote:
> P9LE generated instruction is not worse than P8LE.
> mtvsrdd;xxlnot;stxv vs. not;not;std;std.
> Update the test case to fix failures.
So this no longer runs it for p7, and it also doesn't run it for cpus
after p9 anymore. Could you change it to be a test for p9 and above,
and one for before p9? Does that work?
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/pr72804.p8.c
> @@ -0,0 +1,16 @@
> +/* { dg-do compile { target lp64 } } */
> +/* { dg-skip-if "" { powerpc*-*-darwin* } } */
> +/* { dg-require-effective-target powerpc_vsx_ok } */
> +/* { dg-options "-O2 -mvsx -mdejagnu-cpu=power8" } */
-mvsx is implied by power8 (or power7, already).
You don't need the test for Darwin: Darwin never has VSX, already (and
if it somehow would ever get support for it, we'd want this test to run
for it).
> +/* { dg-final { scan-assembler-times "std " 0 } } */
We usually write this as scan-assembler-not, but this works just fine
as well. Whichever you prefer.
Segher