Re: [patch][avr] PR92055: Add switches to enable 64-bit [long] double.

[Georg-Johann Lay <avr at gjlay dot de>]

Am 07.11.19 um 13:49 schrieb Martin Liška:
> On 11/7/19 1:39 PM, Georg-Johann Lay wrote:
> > Am 07.11.19 um 10:41 schrieb Martin Liška:
> > > Hello.
> > >
> > > I've noticed quite some GNU coding style violations with your patch.
> > > Please next time, use something like:
> > >
> > > $ git diff HEAD~ > /tmp/patch && ./contrib/check_GNU_style.py /tmp/patch
> > >
> > > Thanks,
> > > Martin
> >
> > hm, I am actually using GNU style with Emacs...
> >
> > You mean the lines > 80 chars in config.gcc?
> >
> > I assumed that is no issue because there are already quite some lines 
> > that don't follow the < 80 rule.
>
> That's fine. I'm mainly talking about:
>
> === ERROR type #1: blocks of 8 spaces should be replaced with tabs (45 
> error(s)) ===
> gcc/common/config/avr/avr-common.c:78:0:████████████████   const struct 
> cl_decoded_option *decoded, location_t loc)
> gcc/common/config/avr/avr-common.c:86:0:████████{
> gcc/common/config/avr/avr-common.c:88:0:████████  error_at (loc, "option 
> %<-mdouble=64%> is only available if "
> gcc/common/config/avr/avr-common.c:89:0:████████████████    "configured 
> %<--with-double={64|64,32|32,64}%>");
> gcc/common/config/avr/avr-common.c:91:0:████████  
> opts->x_avr_long_double = 64;
> gcc/common/config/avr/avr-common.c:92:0:████████}
> gcc/common/config/avr/avr-common.c:94:0:████████{
> ...
>
> Martin

My intention was to avoid a mixup of TABs and spaces mode, because
the avr backend is indented with spaces. So the indentation picks
up the style from the context (just like ypi would do it in Python
to avoid dreaded mixing of tabs ans spaces). Tabyfying the complete
sources is also something which I didn't consider, because that
makes porting much harder...

Johann