This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][vect] Clean up orig_loop_vinfo from vect_analyze_loop
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: "Andre Vieira \(lists\)" <andre dot simoesdiasvieira at arm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <rguenther at suse dot de>
- Date: Fri, 01 Nov 2019 09:54:06 +0000
- Subject: Re: [PATCH][vect] Clean up orig_loop_vinfo from vect_analyze_loop
- References: <451cd999-1fa1-f502-455b-de2348db181c@arm.com>
"Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com> writes:
> Hi,
>
> After my patch I believe the only way orig_loop_vinfo is not null when
> calling vect_analyze_loop is when it is called for an epilogue and in
> that case we no longer use that variable, since
> LOOP_VINFO_ORIG_LOOP_INFO is already set for the epilogue's
> loop_vec_info. This patch removes that parameter.
>
> Bootstrapped on x86_64 and aarch64.
>
> Is this OK for trunk?
>
> Cheers,
> Andre
>
> gcc/ChangeLog:
> 2019-10-31 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * tree-vect-loop.c (vect_analyze_loop): Remove orig_loop_vinfo
> parameter.
> * tree-vectorizer.h (vect_analyze_loop): Update declaration.
> * tree-vectorizer.c (try_vectorize_loop_1): Update calls to
> vect_analyze_loop.
OK with...
> diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c
> index 9b7d2485b7cae81578c6a7d33304dc48134cc850..f3deada90cb30c3d5a69a8ca243b0b7687d356cc 100644
> --- a/gcc/tree-vect-loop.c
> +++ b/gcc/tree-vect-loop.c
> @@ -2352,8 +2352,7 @@ again:
> loop_vec_info struct. If ORIG_LOOP_VINFO is not NULL epilogue must
> be vectorized. */
> opt_loop_vec_info
> -vect_analyze_loop (class loop *loop, loop_vec_info orig_loop_vinfo,
> - vec_info_shared *shared)
> +vect_analyze_loop (class loop *loop, vec_info_shared *shared)
> {
> auto_vector_sizes vector_sizes;
...removing the "If ORIG_LOOP_VINFO is not NULL ..." comment too.
Thanks,
Richard