This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Come up with json::integer_number and use it in GCOV.
PING^2
On 8/26/19 2:34 PM, Martin Liška wrote:
> PING^1
>
> On 8/13/19 1:51 PM, Martin Liška wrote:
>> On 8/2/19 2:40 PM, David Malcolm wrote:
>>> Something that occurred to me reading the updated patch: maybe it would
>>> make things easier to have utility member functions of json::object to
>>> implicitly make the child, e.g.:
>>>
>>> void
>>> json::object::set (const char *key, long v)
>>> {
>>> set (key, new json::integer_number (v));
>>> }
>>>
>>> so that all those calls can be just:
>>>
>>> obj->set ("line", exploc.line);
>>> obj->set ("column", exploc.column);
>>>
>>> etc (assuming overloading is unambiguous).
>>>
>>> But that's probably orthogonal to this patch.
>>
>> Looks good to me. It's a candidate for a follow up patch.
>>
>>>
>>>
>>>> And I changed all occurrences of float_number with integer_number
>>>> as you suggested.
>>> Thanks.
>>>
>>>> I'm currently testing the updated patch.
>>>> Martin
>>> The updated patch looks good to me, but technically I'm not a reviewer
>>> for these files.
>>
>> Sure, I hope @Jakub or @Richi can approve me that?
>> Thanks,
>> Martin
>>
>>>
>>> Dave
>>
>