This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0


On Thu, Aug 22, 2019 at 10:59 PM Jim Wilson <jimw@sifive.com> wrote:
> With a rv64gc/lp64d linux toolchain, I get 43 extra gcc failures.  For
> C++ and Fortran I get a lot of link errors, so the results aren't very
> useful.  Apparently we never tested this before.
> /scratch/jimw/fsf-testing/X-tmp-unpatched-64/build-install/riscv64-unknown-linux-gnu/bin/ld:
> linker_plugin30724.exe: hidden symbol `__riscv_save_0' in
> /scratch/jimw/fsf-testing/X-tmp-unpatched-64/build-gcc-linux-stage2/gcc/testsuite/g++/../../libgcc.a(save-restore.o)
> is referenced by DSO
> Not sure why it is marked hidden, as we aren't using any visibility
> directives.  Looks like I will have to add this to my todo list also.

The problem with the linux toolchain support for -msave-restore is
that we forgot to add a version script to export the symbols.  I made
the obvious change to add a RISC-V specific libgcc version script, and
now everything in the g++ and gfortran testsuites are linking, but the
execution tests are all timing out.  So there is still something
wrong.  I need to do some more work here.

Jim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]