This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.

From: Jan Hubicka <hubicka at ucw dot cz>
To: Martin Liška <mliska at suse dot cz>
Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 24 Aug 2019 00:36:22 +0200
Subject: Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
References: <55b4acda-9673-557b-5819-50bff07fa095@suse.cz> <CAFiYyc25R6e5R78HXtLh-tu4BVWmkEi_JwEs0AgO9XVm=0dBdA@mail.gmail.com> <20190815143341.m4t76ewfi4zn3ayl@kam.mff.cuni.cz> <7c27efd6-e9dd-ac4f-ebaf-6626a226bb61@suse.cz> <1d1856dc-6e42-89ad-85ee-519b1a691afd@suse.cz> <20190823143728.favozczljnminl4d@kam.mff.cuni.cz> <bbc38fef-89ce-c433-209c-3dcd722d6ea5@suse.cz> <20190823150502.l4dnv3fxzsfhro4g@kam.mff.cuni.cz> <b00ee4a3-2246-b146-d489-09535203b557@suse.cz>

> 
> Sorry, I mean the hash which we use in LGEN even now. So e.g.:
> 
> readelf -S -W main.o
> There are 17 section headers, starting at offset 0x958:
> 
> Section Headers:
>   [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
> ...
>   [ 6] .gnu.lto_main.e4fa533f2618f732 PROGBITS        0000000000000000 00007c 000287 00   E  0   0  1
> 
> So my question should be if we want $name.$order as a section name?

Aha, I see.  Those hashes are there to let ld -r to link LTO files.
Different sections will just get copied into the output file and will
happen to work.  Yes, I think we want to keep this hash.

Honza
> 
> Martin
> 
> > 
> > Honza
> >>
> >> Thanks,
> >> Martin
> >>
> >>>
> >>> Honza
> >>>>
> >>>> Martin
> >>
>

Follow-Ups:
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Martin Liška

References:
- [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Martin Liška
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Richard Biener
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Jan Hubicka
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Martin Liška
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Martin Liška
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Jan Hubicka
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Martin Liška
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Jan Hubicka
- Re: [PATCH] Prevent LTO section collision for a symbol name starting with '*'.
  - From: Martin Liška

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]