This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Builtin function roundeven folding implementation
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Martin Jambor <mjambor at suse dot cz>
- Cc: Tejas Joshi <tejasjoshi9673 at gmail dot com>, <gcc-patches at gcc dot gnu dot org>, <hubicka at ucw dot cz>
- Date: Wed, 21 Aug 2019 12:00:50 +0000
- Subject: Re: [PATCH] Builtin function roundeven folding implementation
- Ironport-sdr: 1GL92f0sRKoTFJ775ifWqmagTshMRk0T/SfZ2RF/lokZsiFuRAmI5rdadjU1hQ2Twtd4GEg8FM 4bracwzrHSt9d27k8RRBPWQFGNqp53rbQBLEOzZp6JQgzG1HzNORU904zE62YjYBISY/1ETRmr RQQbQSUtSH/lnKGROGWGx7lHKB21mpJBV+ezXB8JsiNmyOzvYtVmAZFWQALe/ArDWZtiinE//r TuBRe9iyDTrIzS2aRkDGCkpzoisvwnR2YniO8Z/T2ilY5cX+8lOhUJzdbV2KRAUpAHlKpWD4bu AGU=
- Ironport-sdr: 0wXeYZnI2xO0zFv1JzhWtvGTwkr9t4idoPGc15qFobgEkjNt0T262Lh3nb6VqhVBH6VQDU1/cO VxICZKJx9z+MpoSnDsC9TmveeO+97QIHr8mHHbabPG6Wz0i8BTpT90xEfwsbXkug+o8s8gXneK FQQuwlvWBM12KuSllKTvVw8BN3YA17oTyMLjKt02OKKzG/GHtwldAidN19MFg/Gdow07lBpulN 8sESS2Jq/+YeZAe21vtDLLXtqCgQ6ikf08+bm/C7Kyg+Du62RfgJSwhDpVFEQFJFeJiucJTbl1 KUI=
- References: <CACMrGjCu54zN+Smc7+3JF8MBZV76HXwaP-vk1HFTQGhRc=Toww@mail.gmail.com> <alpine.DEB.2.21.1908092021090.31221@digraph.polyomino.org.uk> <CACMrGjCPNr+Hjz--CL6ocV5y3GqGp13fpQCXtXJT4qeGQWk86A@mail.gmail.com> <ri636hug2zr.fsf@suse.cz>
On Wed, 21 Aug 2019, Martin Jambor wrote:
> Hi Tejas,
>
> On Wed, Aug 14 2019, Tejas Joshi wrote:
> > Hi.
> > Here is a clean patch that does not fold roundeven resulting for
> > integer type and the conditions for folding functions
> > round/ceil/floor/roundeven and trunc only checks for signaling NaN.
>
> wouldn't checking for *signalling* NaNs mean using the macro
> REAL_VALUE_ISSIGNALING_NAN rather than REAL_VALUE_ISNAN?
Yes, it would. So the patch should be retested / reposted with that
change.
> > \ No newline at end of file
This should be fixed (in both places, the tests should each end with
exactly one newline character).
The new built-in functions roundeven / roundevenf / roundevenl also need
to be added to the lists in extend.texi (the list of GNU extension
functions for now, though once we add DEF_C2X_BUILTIN they'd go in a list
of C2X built-in functions instead).
--
Joseph S. Myers
joseph@codesourcery.com