This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fwd: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: John David Anglin <dave dot anglin at bell dot net>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 20 Aug 2019 15:43:46 +0000
- Subject: Re: Fwd: [PATCHv5] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=75cHv2XpKl4vkF6DJO8ZYi5u10BpILw9sgnSGMYbxT4=; b=CbV3RDuoWjeXWaO4ZaoN0/j7ZiW1SXKrZ8eFvg2B30z8TNT4x9m3PYqk+HXYqgCuGa3TY81K5l16vU01K6zQzCSOyDjPsxzCLZzM1JyIIyHXitgtbdxo1BPHw7sHy4E0SOtz8sE0U0qwmQ7ZAQLLE/c/uQWMqn+HsnNmuRsxg8FV4x42SlQF6kyNWGEJ5uoJouMCVUrPSvxHsY17SzD+ze3tvM0axZhYHv2SP1k1m2GXVLCOyosszZQV65M8NElcNBiQ8cY1hetiRfs3CwtUjHvy3ckQWBC91BApc6EbjTkSbVVEICgD7my7REQw3cc49V8gS8Q0i/2H5TEDum+XwQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DzRHclFHRfbPirwtBwtIKiXJc5aGJKYkROB4iIBepy/K8FMjYhsU7rZIKLCiBSDpARHyCOYvRSQ9EQoEWQUq6i8OK9Kfvob244ICZFRXbxKRxxT9wTeYdXTZ6idAFgde00EVq8OcPhBn8yG4zWW5QkWWP/dv+gWfykpz7G+ouvY0WWRqk6Rg1BZOmcKh8DOyAhHHxHTZ5dwBTPxsNRdtddcC3TlHNh0/6IFt2Zt8j1G1lgPNU0INAapzuvdAT6cBu8Q5Ey0tdRBg3f+tFHvkbZZsjcGxfGVVYX9rbjXLYe8e/4sOgKNkC0DMPJ/xtvK07E01uLudGnM33jDtot+ZmA==
- References: <23798c01-d456-a287-8020-505fd316a841@bell.net> <0d39b64f-67d9-7857-cf4e-36f09c0dc15e@bell.net>
Ah, yes that was unexpected...
Sorry for the breakage.
So this needs to be known_eq (STACK_POINTER_OFFSET, 0)
instead of STACK_POINTER_OFFSET == 0 obviously.
Should be fixed by this patch, which I am going to commit
as "obvious" in a moment unless someone objects.
Thanks
Bernd.
On 8/20/19 4:39 PM, John David Anglin wrote:
> On 2019-08-15 3:47 p.m., Bernd Edlinger wrote:
>> 2019-08-15 Bernd Edlinger <bernd.edlinger@hotmail.de>
>>
>> PR middle-end/89544
>> * function.c (assign_parm_find_stack_rtl): Use larger alignment
>> when possible.
> This patch breaks build on hppa-unknown-linux-gnu:
> https://buildd.debian.org/status/fetch.php?pkg=gcc-snapshot&arch=hppa&ver=1%3A20190820-1&stamp=1566307455&raw=0
>
> hppa-linux-gnu-g++-9 -std=gnu++98 -fno-PIE -c -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../src/gcc -I../../src/gcc/. -I../../src/gcc/../include -I../../src/gcc/../libcpp/include -I../../src/gcc/../libdecnumber -I../../src/gcc/../libdecnumber/dpd -I../libdecnumber -I../../src/gcc/../libbacktrace -o function.o -MT function.o -MMD -MP -MF ./.deps/function.TPo ../../src/gcc/function.c
> hppa-linux-gnu-g++-9 -std=gnu++98 -fno-PIE -c -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../src/gcc -I../../src/gcc/. -I../../src/gcc/../include -I../../src/gcc/../libcpp/include -I../../src/gcc/../libdecnumber -I../../src/gcc/../libdecnumber/dpd -I../libdecnumber -I../../src/gcc/../libbacktrace -o function-tests.o -MT function-tests.o -MMD -MP -MF ./.deps/function-tests.TPo ../../src/gcc/function-tests.c
> hppa-linux-gnu-g++-9 -std=gnu++98 -fno-PIE -c -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../src/gcc -I../../src/gcc/. -I../../src/gcc/../include -I../../src/gcc/../libcpp/include -I../../src/gcc/../libdecnumber -I../../src/gcc/../libdecnumber/dpd -I../libdecnumber -I../../src/gcc/../libbacktrace -o fwprop.o -MT fwprop.o -MMD -MP -MF ./.deps/fwprop.TPo ../../src/gcc/fwprop.c
> ../../src/gcc/function.c: In function 'void assign_parm_find_stack_rtl(tree, assign_parm_data_one*)':
> ../../src/gcc/function.c:2690:28: error: no match for 'operator==' (operand types are 'poly_int<1, long long int>' and 'int')
> 2690 | && STACK_POINTER_OFFSET == 0)
> | ^~ ~
> | |
> | int
> In file included from ../../src/gcc/coretypes.h:415,
> from ../../src/gcc/function.c:36:
> ../../src/gcc/wide-int.h:3287:19: note: candidate: 'template<class T1, class T2> typename wi::binary_traits<T1, T2>::predicate_result operator==(const T1&, const T2&)'
> 3287 | BINARY_PREDICATE (operator ==, eq_p)
> | ^~~~~~~~
> ../../src/gcc/wide-int.h:3264:3: note: in definition of macro 'BINARY_PREDICATE'
> 3264 | OP (const T1 &x, const T2 &y) \
> | ^~
> ../../src/gcc/wide-int.h:3287:19: note: template argument deduction/substitution failed:
> 3287 | BINARY_PREDICATE (operator ==, eq_p)
> | ^~~~~~~~
> ../../src/gcc/wide-int.h:3264:3: note: in definition of macro 'BINARY_PREDICATE'
> 3264 | OP (const T1 &x, const T2 &y) \
> | ^~
> ../../src/gcc/wide-int.h: In substitution of 'template<class T1, class T2> typename wi::binary_traits<T1, T2>::predicate_result operator==(const T1&, const T2&) [with T1 = poly_int<1, long long int>; T2 = int]':
> ../../src/gcc/function.c:2690:31: required from here
> ../../src/gcc/wide-int.h:3287:19: error: incomplete type 'wi::int_traits<poly_int<1, long long int> >' used in nested name specifier
> 3287 | BINARY_PREDICATE (operator ==, eq_p)
> | ^~~~~~~~
> ../../src/gcc/wide-int.h:3264:3: note: in definition of macro 'BINARY_PREDICATE'
> 3264 | OP (const T1 &x, const T2 &y) \
> | ^~
> make[5]: *** [Makefile:1118: function.o] Error 1
> make[5]: *** Waiting for unfinished jobs....
>
> We have the following define for STACK_POINTER_OFFSET:
>
> #define STACK_POINTER_OFFSET \
> (TARGET_64BIT ? -(crtl->outgoing_args_size + 48) : poly_int64 (-32))
>
> Dave
>
2019-08-20 Bernd Edlinger <bernd.edlinger@hotmail.de>
* function.c (assign_parm_find_stack_rtl): Use known_eq instead of ==.
Index: gcc/function.c
===================================================================
--- gcc/function.c (revision 274691)
+++ gcc/function.c (working copy)
@@ -2706,7 +2706,7 @@ assign_parm_find_stack_rtl (tree parm, struct assi
stack slot boundary, take advantage of that excess alignment.
Don't make any assumptions if STACK_POINTER_OFFSET is in use. */
if (poly_int_rtx_p (offset_rtx, &offset)
- && STACK_POINTER_OFFSET == 0)
+ && known_eq (STACK_POINTER_OFFSET, 0))
{
unsigned int offset_align = known_alignment (offset) * BITS_PER_UNIT;
if (offset_align == 0 || offset_align > STACK_BOUNDARY)