This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/9] Come up with an abstraction.
On Tue, Aug 6, 2019 at 5:44 PM Martin Liska <mliska@suse.cz> wrote:
>
>
> gcc/ChangeLog:
Hum. I don't like the "abstraction" - how is it going to help you to not
duplicate all the code? What's wrong with doing this all in ICF?
Richard.
> 2019-07-24 Martin Liska <mliska@suse.cz>
>
> * fold-const.c (operand_equal_p): Rename to ...
> (operand_compare::operand_equal_p): ... this.
> (add_expr): Rename to ...
> (operand_compare::hash_operand): ... this.
> (operand_compare::operand_equal_valueize): Likewise.
> (operand_compare::hash_operand_valueize): Likewise.
> * fold-const.h (operand_equal_p): Set default
> value for last argument.
> (class operand_compare): New.
> * tree.c (add_expr): Move content to hash_operand.
> ---
> gcc/fold-const.c | 346 ++++++++++++++++++++++++++++++++++++++++++++++-
> gcc/fold-const.h | 30 +++-
> gcc/tree.c | 286 ---------------------------------------
> 3 files changed, 372 insertions(+), 290 deletions(-)
>