This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 4/9] Strengthen alias_ptr_types_compatible_p in LTO mode.
On Thu, Aug 8, 2019 at 12:04 PM Martin Liška <email@example.com> wrote:
> On 8/7/19 1:57 PM, Richard Biener wrote:
> > On Tue, Aug 6, 2019 at 5:43 PM Martin Liska <firstname.lastname@example.org> wrote:
> > This warrants a comment like
> > /* This function originally abstracts from simply comparing
> > get_deref_alias_set
> > so that we are sure this still computes the same result after LTO
> > type merging
> > is applied. When in LTO type merging is done we can actually do
> > this compare. */
> > if (in_lto_p)
> > return get_deref_alias_set (t1) == get_deref_alias_set (t2);
> > ...
> > also note you want to call get_deref_alias_set as mentioned in the
> > function comment.
> Thanks for review.
> Hope it's addressed in the attached patch that I've just tested?
> > OK with this change.
> > Thanks,
> > Richard.
> >> gcc/ChangeLog:
> >> 2019-07-24 Martin Liska <email@example.com>
> >> * alias.c (alias_ptr_types_compatible_p): Strengten
> >> type comparison in LTO mode.
> >> ---
> >> gcc/alias.c | 7 +++++--
> >> 1 file changed, 5 insertions(+), 2 deletions(-)