This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/9] ifcvt: Only created temporaries as needed.

From: Robin Dapp <rdapp at linux dot ibm dot com>
To: gcc-patches at gcc dot gnu dot org, james dot greenhalgh at arm dot com, richard dot sandiford at arm dot com
Date: Thu, 8 Aug 2019 11:01:20 +0200
Subject: Re: [PATCH 3/9] ifcvt: Only created temporaries as needed.
References: <20190802151028.15590-1-rdapp@linux.ibm.com> <20190802151028.15590-4-rdapp@linux.ibm.com> <mptzhkm6p2c.fsf@arm.com>

Hi Richard,

> Is the separate need_temps scan required for correctness?  It looked
> like we could test:
> 
>       if (reg_overlap_mentioned_p (dest, cond))
> 	...
> 
> on-the-fly during the main noce_convert_multiple_sets loop.

right, I didn't re-check it but after changes during interal patch
rounds the check is now degenerated enought to allow this. Going to
refactor that.

> Would it work to set temporaries[i] to targets[i] whenever a temporary
> isn't needed, and avoid temps_created?

Yes, that should work. Already made that change locally.

Regards
 Robin

References:
- [PATCH 0/9] Improve icvt "convert multiple"
  - From: Robin Dapp
- [PATCH 3/9] ifcvt: Only created temporaries as needed.
  - From: Robin Dapp
- Re: [PATCH 3/9] ifcvt: Only created temporaries as needed.
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]