This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Teach mklog to reference PRs.


On 8/2/19 9:48 AM, Jakub Jelinek wrote:
> On Fri, Aug 02, 2019 at 08:04:11AM +0200, Martin Liška wrote:
>> On 8/2/19 7:45 AM, Martin Liška wrote:
>>> I agree with that approach.
>>
>> I'm sending an example how it would look like for something
>> bigger:
>>
>> $ git diff e8a3be407068bfb9c82f0f6656b30d26cc2f484a~15..e8a3be407068bfb9c82f0f6656b30d26cc2f484a > patch && ./contrib/mklog patch > changelog.txt
>>
>> Thoughts?
> 
> Looks good to me, though of course I wonder what others have to say (if
> anyone cares).

Sure, let's wait for some time now.

> 
>> 	* testsuite/23_containers/array/comparison_operators/constexpr.cc: New test.
>> 	* testsuite/23_containers/array/tuple_interface/get_neg.cc (std::get):
>> 	* testsuite/23_containers/array/tuple_interface/tuple_element_neg.cc:
>> 	* testsuite/25_algorithms/adjacent_find/constexpr.cc: New test.
>> 	* testsuite/25_algorithms/all_of/constexpr.cc: New test.
>> 	* testsuite/25_algorithms/any_of/constexpr.cc: New test.
>> 	* testsuite/25_algorithms/binary_search/constexpr.cc: New test.
>> 	* testsuite/25_algorithms/constexpr_macro.cc: New test.
>> 	* testsuite/25_algorithms/copy/58982.cc (test01):
>> 	* testsuite/25_algorithms/copy/constexpr.cc: New test.
>> 	* testsuite/25_algorithms/copy/move_iterators/69478.cc (test01):
>> 	* testsuite/25_algorithms/copy_backward/constexpr.cc: New test.
>> 	* testsuite/25_algorithms/copy_backward/move_iterators/69478.cc (test01):
> 
> Just a nit, some lines are too long and perhaps mklog could be improved too.
> On the first line above, one would normally wrap it as:
> 	* testsuite/23_containers/array/comparison_operators/constexpr.cc:
> 	New test.
> and on the last line above
> 	* testsuite/25_algorithms/copy_backward/move_iterators/69478.cc
> 	(test01):
> 
> 	Jakub
> 

Good idea. What limit are we targeting in ChangeLog entries? 60 chars?

Martin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]