This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/4] Fix GNU coding style.
On 11/7/18 10:17 AM, Jakub Jelinek wrote:
> On Wed, Nov 07, 2018 at 10:12:17AM +0100, Martin Liška wrote:
>> /* Register memory allocation descriptor for container PTR. ORIGIN identifies
>> type of container and GGC identifes if the allocation is handled in GGC
>> memory. Each location is identified by file NAME, LINE in source code and
>> FUNCTION name. */
>> - T * register_descriptor (const void *ptr, mem_alloc_origin origin,
>> + T *register_descriptor (const void *ptr, mem_alloc_origin origin,
>> bool ggc, const char *name, int line,
>> const char *function);
>
> This can't be right, if you move the ( one column to the left, then the
> following lines need to be moved one column to the left too. Likewise
> below:
Thanks, I noticed that and installed proper version.
Martin
>
>> @@ -342,7 +342,7 @@ public:
>> /* Release PTR pointer of SIZE bytes. If REMOVE_FROM_MAP is set to true,
>> remove the instance from reverse map. Return memory usage that belongs
>> to this memory description. */
>> - T * release_instance_overhead (void *ptr, size_t size,
>> + T *release_instance_overhead (void *ptr, size_t size,
>> bool remove_from_map = false);
>>
>> /* Release intance object identified by PTR pointer. */
>> @@ -355,7 +355,7 @@ public:
>> are filtered by ORIGIN type, LENGTH is return value where we register
>> the number of elements in the list. If we want to process custom order,
>> CMP comparator can be provided. */
>> - mem_list_t * get_list (mem_alloc_origin origin, unsigned *length,
>> + mem_list_t *get_list (mem_alloc_origin origin, unsigned *length,
>> int (*cmp) (const void *first,
>> const void *second) = NULL);
>>
>
> Jakub
>