This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Small typo in iconv.m4
- From: Hafiz Abid Qadeer <abid_qadeer at mentor dot com>
- To: <gcc-patches at gcc dot gnu dot org>
- Cc: <gdb-patches at sourceware dot org>, <binutils at sourceware dot org>
- Date: Tue, 6 Nov 2018 16:37:23 +0000
- Subject: Small typo in iconv.m4
Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.
The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"
OK to commit the attached patch?
2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
Append $INCICONV to it.
* gcc/configure: Regenerate.
* libcpp/configure: Likewise.
* libstdc++-v3/configure: Likewise.
* intl/configure: Likewise.
Thanks,
--
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
diff --git a/config/iconv.m4 b/config/iconv.m4
index 5f9304a6ba..f1e54c5aed 100644
--- a/config/iconv.m4
+++ b/config/iconv.m4
@@ -73,7 +73,7 @@ AC_DEFUN([AM_ICONV_LINK],
if test "$am_cv_func_iconv" != yes; then
am_save_CPPFLAGS="$CPPFLAGS"
am_save_LIBS="$LIBS"
- CPPFLAGS="$LIBS $INCICONV"
+ CPPFLAGS="$CPPFLAGS $INCICONV"
LIBS="$LIBS $LIBICONV"
AC_TRY_LINK([#include <stdlib.h>
#include <iconv.h>],