This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.

From: Michael Matz <matz at suse dot de>
To: Martin Liška <mliska at suse dot cz>
Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 5 Nov 2018 18:37:39 +0000 (UTC)
Subject: Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.
References: <02950965-07c6-8008-a95b-413f9e0f53b7@suse.cz> <CAFiYyc0vAEXNHgadYNScHjcPBV4Ys2u0zhJGJMfE_sr-s+uPrw@mail.gmail.com> <8be51451-7b11-84d0-7efb-620371433f6b@suse.cz> <35e46d42-e27a-dc77-922b-61c860cca6ff@suse.cz>

Hi,

On Fri, 2 Nov 2018, Martin Liška wrote:

> V2 of the patch.
> 
> Thoughts?

Whereever the new function belongs it certainly isn't system.h.  Also the 
definition in a header seems excessive.  Sure, it enables inlining of it, 
but that seems premature optimization.  It contains a loop, and inlining 
anything with loops that aren't very likely to loop just once or never 
just blows code for no gain.  Also as the function is leaf there won't be 
any second-order effect from inlining.

Ciao,
Michael.

Follow-Ups:
- Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.
  - From: Martin Liška

References:
- Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.
  - From: Richard Biener
- Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.
  - From: Martin Liška
- Re: [PATCH] Come up with htab_hash_string_vptr and use string-specific if possible.
  - From: Martin Liška

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]