This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][rs6000] fix ICE for strncmp expansion on power6
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Aaron Sawdey <acsawdey at linux dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot ibm dot com>, David Edelsohn <dje dot gcc at gmail dot com>
- Date: Fri, 2 Nov 2018 11:47:39 -0500
- Subject: Re: [PATCH][rs6000] fix ICE for strncmp expansion on power6
- References: <c2b491dc-8bff-c419-c0ab-68a86e876865@linux.ibm.com>
On Fri, Nov 02, 2018 at 09:58:50AM -0500, Aaron Sawdey wrote:
> This patch addresses an ICE for a missing instruction when targeting power6. The issue
> is that we shouldn't generate x-form load rtx if TARGET_AVOID_XFORM is true because
> it won't end up being matched. More generally, on big endian we do not need to use
> ldbrx et. al. which are index loads, but can just use ld and other normal d-form
> loads. So this is going to generate better code for BE in general which is why I have
> changed it to do this for big endian or TARGET_AVOID_XFORM.
Great :-)
> 2018-11-02 Aaron Sawdey <acsawdey@linux.ibm.com>
>
> * config/rs6000/rs6000-string.c (expand_strncmp_gpr_sequence): Pay
> attention to TARGET_AVOID_XFORM.
Also mention BIG_ENDIAN please?
Okay with that. Thanks!
Segher