This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS: Default to --with-llsc for the R5900 Linux target as well


Thank you for your review, Maciej,

> > The Linux kernel requires and emulates LL and SC for the R5900 too. The
> 
>  Two spaces after a full stop please (in commit descriptions too).

Fixed in v2, to be posted shortly.

> I hope this helps you get a general maintainer's approval.

Thanks! It looks like Matthew Fortune is the MIPS port maintainer, so I'm
cc'ing him on this patch.

>  Also your change is small enough to be acceptable right away without a 
> copyright assignment to FSF, however I do recommend that you make one for 
> GCC as well (and also glibc and possibly GDB), as I imagine you'll come up 
> with more changes as you progress with your effort.

Good, yes, I mentioned GCC when I posted the form to the FSF. Implementing
the -mfix-r5900 option is one such change. A small number of fixes related
to floating point instructions, MIPS16, etc. are also needed to make GCC
work with the R5900 target in a reasonable manner.

>  Thank you for your contribution!

You are welcome! :)

Fredrik


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]