This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.
- From: Jeff Law <law at redhat dot com>
- To: Tamar Christina <Tamar dot Christina at arm dot com>, Richard Sandiford <richard dot sandiford at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, "ro at CeBiTec dot Uni-Bielefeld dot DE" <ro at CeBiTec dot Uni-Bielefeld dot DE>, "mikestump at comcast dot net" <mikestump at comcast dot net>
- Date: Thu, 11 Oct 2018 21:17:31 -0600
- Subject: Re: [PATCH][GCC][testsuite] Fix caching of tests for multiple variant runs and update existing target-supports tests.
- References: <20180926134838.GA15583@arm.com> <87efdf2v11.fsf@arm.com> <20180927102327.GA14699@arm.com> <87sh1v192g.fsf@arm.com> <20180927141324.GA24218@arm.com>
On 9/27/18 8:13 AM, Tamar Christina wrote:
>>> The error you would get if you do this is very confusing so I thought
>>> since it didn't matter much for the regexp only target triple tests
>>> that just accepting this would be fine.
>> Seems a good thing that that's a noisy failure; the function should
>> make up its mind whether it wants to cache (use curly braces) or not
>> (just return the expr directly).
>>
>>> Should I drop it or keep it?
>> Think we should either drop it or make it into a more user-friendly
>> error, e.g.:
>>
>> if {[string is true -strict $args] || [string is false -strict $args]} {
>> error {check_cached_effective_target condition already evaluated; did you pass [...] instead of the expected {...}?}
>> } else {
>> set et_cache($prop,$target) [uplevel eval $args]
>> }
>>
> Done, I have also ran a regression test on x86_64 with unix{,-m32} and no fallouts, testsuite is clean.
>
> Attached updated patch with feedback processed.
>
> Ok for trunk?
I don't think this ever got a final approval. If it did I certainly
missed it.
OK for the trunk.
Jeff
ps. You're mighty brave heading into that tcl nonsense... Be careful
you don't get good at it and end up owning it!