This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Remove dead functions and fix VMS target by moving back some functions.
Hi,
On Wed, Oct 10 2018, Martin Liška wrote:
> On 10/9/18 10:34 PM, Martin Jambor wrote:
>> On Tue, Oct 09 2018, Martin Liška wrote:
>>> * ipa-cp.c (ipcp_vr_lattice::meet_with): Likewise.
>>
>> Interesting, I believe that a class representing a lattice should have a
>> meet function with its own type.
>
> I've just tried to put gcc_unreachable there, but can't find anything that
> would trigger an ICE.
Well, I was not saying it is not unused, I was just wondering how that
happened. And after having another look, the answer is that the caller
needs to decide which data to meet according to the return value of
ipa_vr_operation_and_type_effects and so the call to
ipa_vr_operation_and_type_effects cannot be nicely moved into the meet
function, even though that's where seems to belong.
So I guess removing this meet overload is OK, even though strange.
Martin