This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][4/n] Remove BLOCK_ABSTRACT
- From: Jason Merrill <jason at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 8 Oct 2018 13:36:48 -0400
- Subject: Re: [PATCH][4/n] Remove BLOCK_ABSTRACT
- References: <alpine.LSU.2.20.1809281444070.16707@zhemvz.fhfr.qr> <alpine.LSU.2.20.1810051344280.16707@zhemvz.fhfr.qr>
On Fri, Oct 5, 2018 at 7:47 AM Richard Biener <rguenther@suse.de> wrote:
>
> On Fri, 28 Sep 2018, Richard Biener wrote:
>
> >
> > It turns out that nobody sets this anymore (dwarf2out did with the
> > original code of outputting abstract instances, temporarily so IIRC).
> >
> > Bootstrap and regtest running on x86_64-unknown-linux-gnu.
> >
> > Any objection to purge it completely like this?
>
> It's gone now (r264868).
>
> > DECL_ABSTRACT_P is a similar beast but I see the C++ FE still sets it
> > on ctors-in-charge (or so). Is this pure FE use or does the middle-end
> > really need to care about that? I'd possibly turn each DECL_ABSTRACT_P
> > use in the middle-end into an assert but I wonder if you have any
> > thoughts about this.
>
> That question still stands.
Yes, I think it's been obsolete since you removed
set_decl_abstract_flags. My hack in vague_linkage_p will need to
change before we can remove it entirely, though. And I'd want to make
sure that the use in real_symbol_p isn't doing anything useful.
Jason