Re: [PATCH] Come up with gcc/testsuite/g++.target/i386/i386.dg and move there some tests.

[Uros Bizjak <ubizjak at gmail dot com>]

On Mon, Oct 8, 2018 at 1:21 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Mon, Oct 08, 2018 at 01:17:14PM +0200, Martin Liška wrote:
> > I'm suggesting following patch that comes up with new g++.target subfolder.
> > I moved there i386 multiversioning tests.
>
> I think you want Uros to review and decide this one.
>
> > 2018-10-08  Martin Liska  <mliska@suse.cz>
> >
> >       * gcc.target/i386/i386.exp: Include lib/i386.exp.
> >       * g++.target/i386/i386.exp: New file.
> >       * gcc.target/i386/mv*.C: Move here tests and remove
> >       target filter in these tests.
> >       * lib/i386.exp: New file.
>
> My preference would be to move all that content to
> lib/target-supports.exp, next to all the other i386 specific effective
> targets, rather than a new file.  That way it can be used in other
> testsuites too (lib*, gfortran.dg, etc.).

I agree with the above reasoning. These tests were put in i386.exp
with the idea that they will be used only in the gcc.target/i386
directory. This is obviously not the case anymore, and as Jakub
mentioned, their usage will spread to other directories in the future.
So, please simply copy all tests from gcc.target/i386/i386.exp to
target-supports.exp to share them with the new g++.target directory.

Thanks,
Uros.
>         Jakub