This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add new warning flag "warn_prio_ctor_dtor"
- From: Jeff Law <law at redhat dot com>
- To: Vinay Kumar <vinay dot kumar at blackfigtech dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 4 Oct 2018 12:23:56 -0600
- Subject: Re: Add new warning flag "warn_prio_ctor_dtor"
- References: <MA1PR01MB0635D4B919B806195F2FDBA787080@MA1PR01MB0635.INDPRD01.PROD.OUTLOOK.COM> <alpine.DEB.2.21.1808301651410.4027@digraph.polyomino.org.uk> <MA1PR01MB0635E4B54C6F621511666349870F0@MA1PR01MB0635.INDPRD01.PROD.OUTLOOK.COM> <alpine.DEB.2.21.1808311434230.1114@digraph.polyomino.org.uk> <MA1PR01MB06352B8E84663FCB08F865EB870C0@MA1PR01MB0635.INDPRD01.PROD.OUTLOOK.COM>
On 9/3/18 8:48 AM, Vinay Kumar wrote:
> Hi Joseph,
>
>>> The documentation is of a new option, not of -Wreturn-type
> Done
>
>>> you should list the option as -Wno-prio-ctor-dtor when documenting
> Done
>
>>> You're not meant to have the literal text ", no ()" in the manual
> Sorry for the confusion. Modified it accordingly
>
>>> I don't see why a g++.dg one is needed as well
> Removed.
>
> Thanks for reviewing the patch and your suggestions.
> Please find attached the modified patch as per your review comments.
> Please review the patch and let me know if its okay?
>
> Thanks,
> Vinay
>
>
> Wprio-ctor-dtor.patch
[ ... ]
THanks. I've installed this on the trunk.
jeff