This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

From: Jonathan Wakely <jwakely at redhat dot com>
To: Glen Fernandes <glen dot fernandes at gmail dot com>
Cc: ville dot voutilainen at gmail dot com, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Thu, 19 Jul 2018 15:40:50 +0100
Subject: Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
References: <CAHVPgz=BsNLPv-Q=uvbF2L8qw1hG3mhJFpU1uudYURddxpxP-Q@mail.gmail.com> <alpine.DEB.2.21.1806161703210.4013@stedding.saclay.inria.fr> <CAFk2RUbAjawC2uAYJig=t9CmZ8DyF3-r-8D8M3YUWBDdrH70QA@mail.gmail.com> <CAHVPgz=j8jVWsK2RcioWTR0b40tyEiiEYDT=fqE7Bfea00oDoQ@mail.gmail.com> <CAHVPgzkOWEpKpS8EDELB2AjKWa=bbZiGs0XOyC-jWAPL_dJevQ@mail.gmail.com> <20180719132522.GK14057@redhat.com> <CAHVPgzkCTsPBL6-_np47E2q1gziXYxEPfEMLP5r4ZA9y4D3Fng@mail.gmail.com> <CAHVPgz=084b+0AfZrS4H1+P13iDoUVPVD94x+nfs7LXcGzFKFg@mail.gmail.com>

On 19/07/18 10:32 -0400, Glen Fernandes wrote:

On Thu, Jul 19, 2018 at 10:01 AM Glen Fernandes wrote:


I was still unclear about that, but I forwarded you an e-mail from
Marshall with his answer when I asked whether libc++'s use of
TriviallyCopyAssignable here was incorrect. Let me know if it applies
here, and if not (and that interpretation of the standard is
incorrect), I'll update the patch to do as you suggest and run the
tests again.

Glen


Attached: patch.txt

Use __builtin_memmove for trivially copyable types

2018-07-19  Glen Joseph Fernandes  <glenjofe@gmail.com>

   * include/bits/stl_algobase.h
   (__copy_move_a): Used __is_trivially_copyable.
   (__copy_move_backward_a): Likewise.

Tested x86_64-pc-linux-gnu.


Ah, that was quick :-)

Can we keep the new test you added in the previous patch? It seems
useful to add anyway.

Follow-Ups:
- Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
  - From: Glen Fernandes
- Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
  - From: Glen Fernandes

References:
- Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
  - From: Glen Fernandes
- Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
  - From: Jonathan Wakely
- Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
  - From: Glen Fernandes
- Re: [PATCH] Use __builtin_memmove for trivially copy assignable types
  - From: Glen Fernandes

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]