This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Asynchronous I/O, take 3
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: Dominique d'Humières <dominiq at lps dot ens dot fr>, Nicolas Koenig <nk at koenigni dot com>, gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 15 Jul 2018 16:21:30 +0200
- Subject: Re: [patch, fortran] Asynchronous I/O, take 3
- References: <CEA30714-AB71-4A70-8AB3-DCD5B1211BCB@lps.ens.fr> <f5e00468-5373-5ffd-67f1-0f197eb1659e@netcologne.de>
Hi Thomas,
>> I am currently testing the patch at
>> https://gcc.gnu.org/ml/fortran/2018-07/msg00008.html
>>
>> so far, so good!
>
>> IMO the tests should go to gfortran.dg (they pass my tests).
>
> I put the asycn_io_*.f90 tests into libgomp.fortran because,
> under Linux, gfortran.dg does not link in pthreads, so the
> tests would not be executed in parallel, and some of them
> would fail.
>
> So, here is the final version. I would really like to get this
> into trunk, and out of the way, so Nicolas and I can focus on
> other things.
I've now regtested the patch on i386-pc-solaris2.11 and
sparc-sun-solaris2.11: no regressions and the new tests all PASS.
However, I still don't understand why you insist on the hack with
putting the async_io_*.f90 tests into the libgomp testsuite. Why not
just make the pthread requirement explicit with
{ dg-require-effective-target pthread }
{ dg-additional-options "-pthread" }
and put them in gfortran.dg where they belong?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University