This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] reject conflicting attributes before calling handlers (PR 86453)
- From: Richard Biener <rguenther at suse dot de>
- To: Martin Sebor <msebor at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 12 Jul 2018 10:46:27 +0200 (CEST)
- Subject: Re: [PATCH] reject conflicting attributes before calling handlers (PR 86453)
- References: <4c30a386-0be0-f796-a651-757d86ee16b4@gmail.com>
On Wed, 11 Jul 2018, Martin Sebor wrote:
> The attached change set adjusts the attribute exclusion code
> to detect and reject incompatible attributes before attribute
> handlers are called to have a chance to make changes despite
> the exclusions. The handlers are not run when a conflict is
> found.
>
> Tested on x86_64-linux. I expected the fallout to be bigger
> but only a handful of tests needed adjusting and the changes
> all look like clear improvements. I.e., conflicting attributes
> that diagnosed as being ignored really are being ignored as one
> would expect.
OK.
Note the LTO testcase is now redundant after my commit so you can
omit it.
Thanks,
Richard.