This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][OBVIOUS] Add missing Optimization attribute.


On 07/10/2018 10:01 AM, Andre Vieira (lists) wrote:
> On 09/07/18 09:11, Martin Liška wrote:
>> Hi.
>>
>> I'm putting back what I accidentally removed.
>>
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2018-07-09  Martin Liska  <mliska@suse.cz>
>>
>> 	* common.opt: Add back wrongly removed attribute.
>> ---
>>  gcc/common.opt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> Hi Martin,
> 
> Re-enabling this option made the test for warnings in gcc.dg/pr84100.c fail.
> 
> Maybe the test needs some adjusting?
> 
> Cheers,
> Andre
> 

Following patch fixes that. I've tested the patch and I'm going to install it.

Martin
>From d375378fc6c61e0c279a75565cc2195b4fa54fab Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 10 Jul 2018 16:42:23 +0200
Subject: [PATCH] Change dg-warning to db-bogus in a test-case (PR
 testsuite/86445).

gcc/testsuite/ChangeLog:

2018-07-10  Martin Liska  <mliska@suse.cz>

        PR testsuite/86445
	* gcc.dg/pr84100.c: Change it back to dg-bogus.
---
 gcc/testsuite/gcc.dg/pr84100.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/pr84100.c b/gcc/testsuite/gcc.dg/pr84100.c
index 676d0c78dea..86fbc4f7a3e 100644
--- a/gcc/testsuite/gcc.dg/pr84100.c
+++ b/gcc/testsuite/gcc.dg/pr84100.c
@@ -8,7 +8,7 @@ __attribute__((optimize ("align-loops=16", "align-jumps=16",
 			 "align-labels=16", "align-functions=16")))
 void
 foo (void)
-{			/* { dg-warning "bad option" } */
+{			/* { dg-bogus "bad option" } */
   for (int i = 0; i < 1024; ++i)
     bar ();
 }
-- 
2.18.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]