This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [committed][gcc][patch] Require sse for testcase on i686.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tamar Christina <tamar dot christina at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, nd at arm dot com, christophe dot lyon at linaro dot org, law at redhat dot com, rguenther at suse dot de, ian at airs dot com
- Date: Sat, 7 Jul 2018 09:50:43 +0200
- Subject: Re: [committed][gcc][patch] Require sse for testcase on i686.
- References: <20180706104640.GA18510@arm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jul 06, 2018 at 11:46:43AM +0100, Tamar Christina wrote:
> This fixes an ABI warning generated on i686-pc-linux-gnu when using
> `vector_size` with no sse enabled explicitly.
>
> Regtested single test on x86_64-pc-linux-gnu with -m32 and no issues.
>
> Committed under the GCC obvious rule.
That is insufficient, I get the FAIL on i686-linux.
You don't really need dg-require-effective-target sse, it is a dg-do compile
time only test and on i?86/x86_64 failures with old assemblers would show up
only when assembling.
But -msse really should be used on all i?86-*-* and x86_64-*-*.
You'd normally get the -msse etc. automatically, but dg-options
is undesirable in gcc.dg/vect/ tests where all those predefined options
are lost that way, dg-additional-options should be used instead (and you can
say use there -O2 -fno-tree-vectorize or whatever you want).
So, if you have spare cycles, please test such change whether it still FAILs
on arm with your patch reverted after such test changes.
> gcc/testsuite/
> 2018-07-06 Tamar Christina <tamar.christina@arm.com>
>
> PR target/84711
> * gcc.dg/vect/pr84711.c: Add -msse for i686 targets.
In the meantime, I've committed following fix as obvious:
2018-07-07 Jakub Jelinek <jakub@redhat.com>
PR target/84711
* gcc.dg/vect/pr84711.c: Remove unnecessary sse
dg-require-effective-target. Add -msse not just on i386-*, but
on all i?86-* and x86_64-*.
--- gcc/testsuite/gcc.dg/vect/pr84711.c.jj 2018-07-06 23:35:44.952791972 +0200
+++ gcc/testsuite/gcc.dg/vect/pr84711.c 2018-07-07 09:43:27.068785902 +0200
@@ -1,8 +1,7 @@
/* { dg-do compile } */
/* { dg-require-effective-target vect_int } */
-/* { dg-require-effective-target sse { target i386*-*-* } } */
/* { dg-options "-O2" } */
-/* { dg-additional-options "-msse" { target i386*-*-* } } */
+/* { dg-additional-options "-msse" { target i?86-*-* x86_64-*-* } } */
typedef int v4si
__attribute__ ((vector_size (16)));
Jakub