This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]]
- From: Jeff Law <law at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, gcc-patches at gcc dot gnu dot org
- Cc: dvlasenk at redhat dot com, Segher Boessenkool <segher at kernel dot crashing dot org>
- Date: Tue, 3 Jul 2018 18:20:35 -0600
- Subject: Re: [PATCH 3/3] Extend -falign-FOO=N to N[:M[:N2[:M2]]]
- References: <cover.1527245880.git.mliska@suse.cz> <afb1c0abe1094cbe50a77c02a343d8e5b0b467a0.1527245880.git.mliska@suse.cz> <9bb1dbf4-b0ef-544c-fb02-b0262a39b87d@redhat.com> <e7326830-9116-b8ba-7e60-7fa5cc3a440d@suse.cz> <82d6c10f-22d3-f2e8-c6b9-55cd6469966b@suse.cz>
On 07/03/2018 01:11 PM, Martin Liška wrote:
> On 07/03/2018 10:53 AM, Martin Liška wrote:
>> Thank you Jeff.
>>
>> I found some issues when doing build of all targets
>> (contrib/config-list.mk).
>> I'll update patch and test that affected cross-compilers still produce
>> same output.
>
> Hello.
>
> I'm done with testing, I bootstrapped and regtested the patch on
> x86_64-linux and ppc64-linux-gnu.
> I also build all cross compilers we have in contrib/config-list.mk and I
> verified that
> results for gcc/gcc/testsuite/gcc.dg/params/blocksort-part.c source file
> is equal for all cross compilers
> that I touched in the patch. I tested these options:
>
> -O2
> -O2 -falign-loops=256
> -O2 -falign-loops=256 -falign-functions=512 -falign-labels=1024
> -falign-jumps=2048
> -O2 -falign-loops=1024 -falign-functions=512 -falign-jumps=2048
> -O2 -falign-loops=256 -falign-jumps=2048
> -O2 -falign-loops=100 -falign-functions=200 -falign-labels=300
> -falign-jumps=400
> -O2 -falign-loops=1111 -falign-functions=1112 -falign-labels=1113
> -falign-jumps=1114
>
> there are no issues except one that are present on current trunk:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86394
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86390
>
> Is the patchset still ready for approval?
Yes.
jeff