This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/3] Introduce auto_string_vec class.
- From: Jeff Law <law at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, David Malcolm <dmalcolm at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 22 Jun 2018 10:15:43 -0600
- Subject: Re: [PATCH 1/3] Introduce auto_string_vec class.
- References: <3c2e7f32-438a-57a3-96a8-3e9d3fc7f605@suse.cz> <1524587261.5688.193.camel@redhat.com> <cabd9b8d-d5a4-b4e4-a28a-07f020a3288a@suse.cz> <1524698011.2961.15.camel@redhat.com> <90a24d87-2fc2-1818-f2ff-eb03e4d099af@suse.cz> <b2f2021b-4124-04a8-5be7-a17738f67175@suse.cz> <1529505683.23999.105.camel@redhat.com> <1372f15b-c8a1-b81e-1204-8900d63e3b5e@suse.cz>
On 06/22/2018 05:06 AM, Martin Liška wrote:
> On 06/20/2018 04:41 PM, David Malcolm wrote:
>> On Mon, 2018-05-14 at 14:50 +0200, Martin Liška wrote:
>>> First part with introduction of auto_string_vec class.
>>>
>> FWIW, I'm fine with the changes to the jit subdir, but I don't think I
>> have approval rights on the vec.h changes.
> Hi.
>
> Good, I'll wait a review from a global reviewer.
>
>> BTW, was the move of vec_alloc in vec.h intentional? (I take it that
>> it's the same before/after, but it seems to have added some churn to
>> the vec.h part of the patch).
> It's not intentional, fixed in attached patch.
>
> Martin
>
>> Dave
>>
>
> 0001-Introduce-auto_string_vec-class.patch
>
>
> From abd1b31ec6807d101bbf868acfbdf3bd02319463 Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Mon, 14 May 2018 14:00:07 +0200
> Subject: [PATCH] Introduce auto_string_vec class.
>
> gcc/ChangeLog:
>
> 2018-05-14 Martin Liska <mliska@suse.cz>
>
> * vec.h (class auto_string_vec): New (moved from auto_argvec).
> (auto_string_vec::~auto_string_vec): Likewise.
>
> gcc/jit/ChangeLog:
>
> 2018-05-14 Martin Liska <mliska@suse.cz>
>
> * jit-playback.c (class auto_argvec): Moved to vec.h.
> (auto_argvec::~auto_argvec): Likewise.
> (compile): Use the renamed name.
> (invoke_driver): Likewise.
OK
jeff