This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH], PowerPC long double transition patches, v2, Patch #7 (fix IBM extended double tests to use __ibm128 as needed)
On Thu, Jun 21, 2018 at 06:07:36PM -0500, Segher Boessenkool wrote:
> On Wed, Jun 20, 2018 at 10:54:18AM -0400, Michael Meissner wrote:
> > This patch fixes the tests in the testsuite that implicitly were expecting long
> > double to be IBM extended double to use __ibm128 if long double is configured
> > to be IEEE 128-bit floating point.
>
> And just always using __ibm128 does not work? That needs fixing then.
As we've discussed before, __ibm128 is only created when the float128 support
is enabled (VSX and Linux). If I changed the tests without adding a condition
to only run it on the appropriate systems, it would give errors on AIX, and
32-bit embedded systems.
> (Perhaps test long double in a separate testcase, too, then, and only run
> that if the appropriate long double type is active).
>
> Patch is okay for now.
>
>
> Segher
>
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA
email: meissner@linux.ibm.com, phone: +1 (978) 899-4797