This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Do not leak location information during inlining
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 21 Jun 2018 10:02:57 +0200
- Subject: Re: [patch] Do not leak location information during inlining
- References: <1830303.IuxID5XYVR@polaris> <CAFiYyc2PenFCuBpbbq1WQoo7Bn+ObejHWrM-5vNhE_Nbjatjcg@mail.gmail.com> <1630136.kv7PaEyCyQ@polaris>
On Wed, Jun 20, 2018 at 4:37 PM Eric Botcazou <ebotcazou@adacore.com> wrote:
>
> > There are fixes in this patch together with the new functionality -
> > can you split
> > those out? I'm thinking of the copy_edges_for_bb hunks as well as
> > the expand_call_inline ones.
>
> Like this?
OK.
Similar factoring of remap_location and copying/remapping edges goto_locus
is a fix worth splitting out (and backporting eventually if a need arises). It
interferes somewhat with the DECL_INGORED parts but IMHO is separate from
those.
Thanks,
Richard.
>
> * tree-inline.c (copy_edges_for_bb): Minor tweak.
> (maybe_move_debug_stmts_to_successors): Also reset the locus of the
> debug statement when resetting its value.
> (expand_call_inline): Copy the locus of the call onto the assignment of
> the return value, if any. Use local variable in more cases.
>
> --
> Eric Botcazou