This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use flags_from_decl_or_type in lto_symtab_merge_p (PR ipa/85248).


On Wed, Jun 20, 2018 at 10:03 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 06/13/2018 01:21 PM, Richard Biener wrote:
> > On Fri, Jun 8, 2018 at 1:10 PM Martin Liška <mliska@suse.cz> wrote:
> >>
> >> Hi.
> >>
> >> Second follow-up patch uses flags_from_decl_or_type in LTO merging
> >> of declarations. Hope it's more cleaner approach.
> >>
> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> >>
> >> Ready to be installed?
> >
> > That doesn't handle the "error" attribute case anymore?
> >
> > We also have attribute_list_equal / attribute_list_contained that could be
> > used here?
>
> You are right, it can't work. Thus I would erase the FIXME comment.
>
> Is it fine?

Ok.

Richard.

> Martin
>
> >
> > Richard.
> >
> >> Martin
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]