This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 01/11] Initial TI PRU GCC port
On Wed, 13 Jun 2018, Dimitar Dimitrov wrote:
> + error ("__delay_cycles() only takes constant arguments");
As in documentation, diagnostics should not use () to indicate that a name
refers to a function (as opposed to referring to a call with no
arguments). However, function names, option names and any other literal
source code text in diagnostics, both this and other diagnostics in the
port, should be enclosed in %< and %> to quote them in the diagnostic
output.
> + error ("__delay_cycles only takes non-negative cycle counts.");
> + error ("__delay_cycles is limited to 32-bit loop counts.");
No '.' at end of diagnostics (and use %<__delay_cycles%>, as above).
--
Joseph S. Myers
joseph@codesourcery.com