This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Fix PR85755: PowerPC Gcc's -mupdate produces inefficient code


On 6/8/18 12:12 PM, Segher Boessenkool wrote:
> On Fri, Jun 08, 2018 at 12:07:34PM -0500, Peter Bergner wrote:
>> On 6/8/18 11:21 AM, Segher Boessenkool wrote:
>>> On Fri, Jun 08, 2018 at 10:35:22AM -0500, Peter Bergner wrote:
>>>> +/* { dg-final { scan-assembler-times {\mstdu\M} 2 } } */
>>>> +/* { dg-final { scan-assembler-not {\mstfdu\M} } } */
>>>
>>> Does this need p8 at all?  Would it be better to just test without -mcpu=,
>>> on just whatever default cpu is thrown at it?  p8 is default for powerpc64le
>>> so it will get plenty coverage.
>>>
>>> You do need an lp64 target btw.
>>
>> I guess I was just following what was reported in the bugzilla, but you
>> are correct, we don't need -mcpu=power8.  How about the following?
> 
> Looks perfect, thanks!

Ok, I committed the patch with the updated test case to trunk.
I'll let that bake over the weekend before committing the backports
to the GCC 7 and 8 release branches.  Thanks!

Peter




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]