This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices

From: Jozef Lawrynowicz <jozef dot l at mittosystems dot com>
To: DJ Delorie <dj at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, nickc at redhat dot com
Date: Wed, 6 Jun 2018 21:59:41 +0100
Subject: Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices
References: <xn4lifslav.fsf@greed.delorie.com>

On 06/06/18 21:38, DJ Delorie wrote:

+	  snprintf (mcu_name, sizeof (mcu_name) - 1, "__%s__", target_mcu);
+	  start_upper = 0;

Can optimize this to 2 :-)

Otherwise OK.


Ah yes. Could also do:

-      for (i = start_upper; i < strlen (mcu_name); i++)
+      for (i = start_upper; i < strlen (mcu_name) - 2; i++)

Follow-Ups:
- Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices
  - From: DJ Delorie

References:
- Re: [PATCH] [MSP430] Fix device name symbol defined for MSP430i series of devices
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]