This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PING] [PATCH] Add a comma to comment in lower_eh_constructs_2
- From: Zhouyi Zhou <zhouzhouyi at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Zhouyi Zhou <zhouzhouyi at gmail dot com>, jakub at redhat dot com
- Date: Mon, 4 Jun 2018 14:56:40 +0800
- Subject: [PING] [PATCH] Add a comma to comment in lower_eh_constructs_2
Hi,
Following patch has not been reviewed for two weeks. I think the
patch is trivial,
it doesn't affect other parts of GCC.
https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01005.html
And I don't have write permission to GCC
Thanks
Zhouyi
On Mon, May 21, 2018 at 12:09 PM, Zhouyi Zhou <zhouzhouyi@gmail.com> wrote:
> Hi
>
> I think the comment in lower_eh_constructs_2 need a comma.
>
> And I don't have write permission to GCC.
>
> Bootstraped on x86-64
>
> Thanks,
> Zhouyi
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
>
> gcc/ChangeLog:
>
> 2018-05-21 Zhouyi Zhou <zhouzhouyi@gmail.com>
> * tree-eh.c (lower_eh_constructs_2): Add a comma to comment.
>
> ---
> gcc/tree-eh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/tree-eh.c b/gcc/tree-eh.c
> index 30c6d9e..06fe748 100644
> --- a/gcc/tree-eh.c
> +++ b/gcc/tree-eh.c
> @@ -2028,7 +2028,7 @@ lower_eh_constructs_2 (struct leh_state *state, gimple_stmt_iterator *gsi)
> /* FALLTHRU */
>
> case GIMPLE_ASSIGN:
> - /* If the stmt can throw use a new temporary for the assignment
> + /* If the stmt can throw, use a new temporary for the assignment
> to a LHS. This makes sure the old value of the LHS is
> available on the EH edge. Only do so for statements that
> potentially fall through (no noreturn calls e.g.), otherwise
> --
> 2.1.4
>