This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH , rs6000] Add missing builtin test cases, fix arguments to match specifications.
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Carl Love <cel at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Fri, 1 Jun 2018 14:54:07 -0500
- Subject: Re: [PATCH , rs6000] Add missing builtin test cases, fix arguments to match specifications.
- References: <1526500393.5107.3.camel@us.ibm.com> <20180517203157.GA17342@gate.crashing.org> <1526593211.5107.5.camel@us.ibm.com> <20180518214051.GE17342@gate.crashing.org> <1526915730.5107.9.camel@us.ibm.com> <20180523182654.GU17342@gate.crashing.org> <1527100777.5107.15.camel@us.ibm.com> <20180523222423.GW17342@gate.crashing.org> <1527608221.13973.6.camel@us.ibm.com>
Hi Carl,
On Tue, May 29, 2018 at 08:37:01AM -0700, Carl Love wrote:
> * gcc.target/powerpc/builtins-3.c: Add tests test_sll_vuill_vuill_vuc,
Stray tab.
> +/* { dg-final { scan-assembler-times "vupklpx" 1 { target le } } } */
> +/* { dg-final { scan-assembler-times "vupklpx" 1 { target be } } } */
> +/* { dg-final { scan-assembler-times "vupkhpx" 1 { target le } } } */
> +/* { dg-final { scan-assembler-times "vupkhpx" 1 { target be } } } */
That is fine of course, but looks a bit silly ;-) Merge them?
> +/* { dg-final { scan-assembler-times "xxlor" 11 { target { be && ilp32 } } } } */
> +/* { dg-final { scan-assembler-times "xxlor" 7 { target { be && lp64 } } } } */
> +/* { dg-final { scan-assembler-times "xxlor" 7 { target le } } } */
You can do this with just "11 { target ilp32 }" and "7 { target lp64 }",
if that makes sense for the test.
> +/* { dg-final { scan-assembler-times {\mrldic\M} 0 { target { be && ilp32 } } } } */
> +/* { dg-final { scan-assembler-times {\mrldic\M} 64 { target { be && lp64 } } } } */
> +/* { dg-final { scan-assembler-times {\mrldic\M} 64 { target le } } } */
Similar.
Looks great otherwise. Okay for trunk. Thanks!
Segher