Re: [PATCH][RFC] Radically simplify emission of balanced tree for switch statements.

[Martin Liška <mliska at suse dot cz>]

On 05/24/2018 02:28 PM, Rainer Orth wrote:
> Hi Martin,
>
> > On 05/21/2018 01:18 PM, Rainer Orth wrote:
> > > Hi Martin,
> > >
> > > > On 05/18/2018 03:55 PM, Rainer Orth wrote:
> > > > > Hi Martin,
> > > > >
> > > > > > So the patch looks fine, only very very slightly binary is produced. I'm
> > > > > > going to install the patch so that
> > > > > > I can carry on more complex patches based on this one.
> > > > >
> > > > > it seems you didn't properly test the testsuite part: I see
> > > > >
> > > > > +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower
> > > > > "Removing basic block"
> > > > > +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower
> > > > > "loop depth 1, count 33333"
> > > > > +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump-not
> > > > > switchlower "Invalid sum"
> > > > > +UNRESOLVED: gcc.dg/tree-prof/update-loopch.c scan-tree-dump-not
> > > > > switchlower "loop depth 1, count 33332"
> > > > >
> > > > > everywhere.  The log has
> > > > >
> > > > > gcc.dg/tree-prof/update-loopch.c: dump file does not exist
> > > > >
> > > > > Obviously you forgot the adapt the dg-final* files for the dumpfile
> > > > > name.  If I do, three of the failures go away, but
> > > > >
> > > > > FAIL: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower1
> > > > > "Removing basic block"
> > > > >
> > > > > remains (on 32 and 64-bit Linux/x86_64).
> > > > >
> > > > > Please fix.
> > > > >
> > > > > 	Rainer
> > > >
> > > > Thanks for opened eyes, following patch will fix that.
> > > > It's quite obvious, I'll install it right after tests will finish.
> > >
> > > unfortunately, it didn't fix either issue:
> > >
> > > * The switchlower -> switchlower1 renames in the dg-final* lines
> > >    (attached) are still necessary to avoid the UNRESOLVED errors.
> > >    Although obvious, I haven't installed them since ...
> > >
> > > * ... even so
> > >
> > > FAIL: gcc.dg/tree-prof/update-loopch.c scan-tree-dump switchlower1 "Removing basic block"
> > >
> > >    remains.
> > >
> > > 	Rainer
> >
> > Hi.
> >
> > You are right, it's using -O2, thus your patch is right. Please install the
> > patch
> > after testing. It's obvious fix.
>
> I've now installed the fix for the dumpfile renaming.  However, you've
> still done nothing about the remaining failure.

Thanks. Is the last remaining one: gcc.dg/tree-prof/update-loopch.c?

Thanks,
Martin

> 	Rainer